PhilipK / BoilR

Synchronize games from other platforms into your Steam library
Apache License 2.0
1.4k stars 40 forks source link

Selecting Images and then Steam ID no longer works on Steam Deck, it crashes #315

Closed moraroy closed 1 year ago

moraroy commented 1 year ago

Describe the bug Both Linux version and windows version crash on Steam deck after selecting Images and Steam ID. To Reproduce Steps to reproduce the behavior:

  1. Go to 'Images'
  2. Click on 'Steam User ID'
  3. Scroll down to 'desired ID' 4.Crashes

    • OS: [Steam Deck]
    • BoilR Version [e.g. v.1.7.19]
    • Launcher (if applicable)
PhilipK commented 1 year ago

@moraroy can you try to share the terminal output? Both the native and flatpak on steam deck ?

moraroy commented 1 year ago

@PhilipK Could not load platform amazon, gave error: Unknown platform named amazon Could not load platform playnite, gave error: Unknown platform named playnite The application panicked (crashed). Message: called Option::unwrap() on a None value Location: src/ui/components/game_image_button.rs:127

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it. Run with RUST_BACKTRACE=full to include source snippets.

PhilipK commented 1 year ago

Thanks. I will have to fix it after work.

PhilipK commented 1 year ago

Weird, it does not fail on my steamdeck, but I can see where the bug might be, so i will have to work on that this evening.

moraroy commented 1 year ago

It may have to do with mine, I've been moving along of folders around maybe I caused an error in my steam id

PhilipK commented 1 year ago

I have a feeling that it is because it can't find your steam folders. Currently I am getting rid of all the places that I made some assumptions (unwrap) about user setup that could cause this crash. But you could try to backup your boilr config file and then delte it. It's found in /home/deck/.config/boilr

On Fri, Jan 6, 2023, 22:34 moraroy @.***> wrote:

It may have to do with mine, I've been moving along of folders around maybe I caused an error in my steam id

— Reply to this email directly, view it on GitHub https://github.com/PhilipK/BoilR/issues/315#issuecomment-1374159237, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEE7DHSAHNOALA2IZJ4CL3WRCFUTANCNFSM6AAAAAATSPEISA . You are receiving this because you were mentioned.Message ID: @.***>

moraroy commented 1 year ago

I deleted the configuration file, and loaded the Linux version back up, re did some of my settings but selecting the steam Id still crashes... one thing I noticed though..

if I select "images" then on the right drop down box select "images for steam games"

Then click on the left drop down box and select "steam ID" it doesn't crash.

It only crashes when "steam ID" is selected and "Images For Shortcuts"

PhilipK commented 1 year ago

@moraroy I made a prerelease here: https://github.com/PhilipK/BoilR/releases/tag/v.1.7.20

It fixes a bunch of possible crashes (it should be almost impossible to crash now). Can you check if it helps?

moraroy commented 1 year ago

You fixed it brother! Nice work. No more crashes on both the Linux version and Windows! I like how "0" is longer there it just goes straight to your ID.

moraroy commented 1 year ago

@PhilipK

PhilipK commented 1 year ago

Super! I will make it an official release, hopefully by tomorrow (after some more testing, but mainly after all 3 kids are asleep :-) )

PhilipK commented 1 year ago

Alright, its released, thanks for reporting this