search

PhilipK / BoilR

Synchronize games from other platforms into your Steam library
Apache License 2.0
1.4k stars 40 forks source link

Add Ubisoft connect (Linux Proton) support #346

Closed Ofacy closed 1 year ago

Ofacy commented 1 year ago

This code might not look good, but it works on my machine hey. I just did the bare minimum to get it working on my steam deck, just wanted to share this.

Quick note about that commit, this is my first time reading and writing rust, this code might not look good or even work on your machine, but I managed to get it working on my steam deck and I wanted to share this with anyone who wants it, so here is my code.

Ofacy commented 1 year ago

This would resolve #255, #215 and #51. Allowing direct use of Ubisoft connect instead of using third party "launcher" steps.

PhilipK commented 1 year ago

This is seriously awesome, thanks! I will look through the code in detail tonight, but great they you got it working

PhilipK commented 1 year ago

For being the first time you have done any Rust I am very impressed.

The errors you are seeing in the pipeline is because I have configured clippy (linter) to disallow any operation that would possibly crash Boilr. I have made the changes locally that would fix this, I guess the best way of getting them into this pull request is by using the suggestions feature.

Ofacy commented 1 year ago

There it should now successfully build for linux too, hope this works. I'll remind myself to take my time next time I wanna commit something instead of pushing 3 commits out of panic.

PhilipK commented 1 year ago

The last problem for window just seems to be a function that needs to be included in that built. Do you have access to a windows machine? Otherwise i can find the fix tonight

Ofacy commented 1 year ago

There this should fix the error, didn't have much time, we might want to make those includes "unix only" to remove the last warnings.