search

PhilipSkinner / windows

MIT License
16 stars 12 forks source link

Cannot set default key value #6

Open nasserakhter opened 2 years ago

nasserakhter commented 2 years ago

We are unable to set the default key value when using the windows/registry package.

let reg = registry("HKLM/Software/microart/nova");
reg.add("(Default)", "Text");

The preceding code simply adds a new key alongside the original "Default" key that is named the same. It does not edit the real "Default" key value.

PhilipSkinner commented 2 years ago

Hey, thanks for the report!

I'm currently away without access to a Windows machine, I'll be back home on Wednesday and I'll take a look for you then.

nasserakhter commented 2 years ago

Hi Philip,

I have created a temporary fix by manually detecting the "(Default)" value and switching the proper flags, all of which can be found in the pull request that was just opened. I hope this makes it a bit easier for you to work on while you are away.

Best Regards

PhilipSkinner commented 2 years ago

Hey thanks for the PR, I got to review it today and I can confirm it works.

I've released 0.1.2 to npm - could you please confirm that its working and close this ticket? If not I'll close this down in a week or so!

Thanks for contributing :)