PhilipTrauner / cmus-osx

Adds track change notifications and media key support to cmus.
MIT License
178 stars 9 forks source link

version 2.0 roadmap #8

Closed azadkuh closed 7 years ago

azadkuh commented 7 years ago

this is an open discussion about the future release of cmus-osx due to new design mostly done by @PhilipTrauner.

there are some missing features or issues in current master branch in comparison to the older releases (i.e. v1.2):

PhilipTrauner commented 7 years ago

Some more suggestion: The hardware buttons of Earpods (or any other headphones for that matter) don't work. I already tried hacking together a solution in Python with MediaPlayer, but could not get the callback functionality to accept a python function wrapped in a selector. If I don't find a solution I might have to rewrite cmus-osx in Swift or ObjC. I really don't want to essentially start from scratch again, so this is more of a last resort thing.

Locking for media-key.py should also be implemented. If cmus is relaunched very quickly it might produce two or more instances which really messes up the controls.

Better inline documentation. Documentation generator is overkill, still there is some pyobjc stuff in notify.py that took me ages to find.

If a new logo is found I suggest a rewrite of the README to be extra fancy.

PhilipTrauner commented 7 years ago

Sorry for the silence, I will dedicate my weekend to:

PhilipTrauner commented 7 years ago

It's been a while but I think the v2.0.0 milestone is finally reached. Streaming notification work again and iTunes doesn't pop-up anymore when media keys are pressed.

I don't want to sound egotistical but would you mind transferring the repository ownership to me?

azadkuh commented 7 years ago

dear @PhilipTrauner you already have full control on this repo and most of its credit goes to you.

would you mind transferring the repository ownership to me?

sure!

PhilipTrauner commented 7 years ago

@azadkuh Thank you so much! Your project is in good hands 😎

rtaibah commented 6 years ago

Love this project. Any updates on notifications when streaming?

PhilipTrauner commented 6 years ago

@rtaibah Just tried out a random stream and everything seemed to work. Would you mind posting the url of the stream you are having trouble with?