search

Philipp15b / go-steam

Steam's protocol in Go to allow automation of different actions on the Steam network without running an actual Steam client. Includes APIs for friends, chatting, trading, trade offers and TF2 crafting.
https://pkg.go.dev/github.com/Philipp15b/go-steam/v3
Other
391 stars 131 forks source link

gs-bot returns connection failure on successful connection #112

Closed OutOfBears closed 3 years ago

OutOfBears commented 3 years ago

When attempting to connect using the gs-bot the connection to the steam can be established using a random server, but the connect function returns false, even though the successful connection was made. While looking, I assume a simple fix to this issue could be just returning true, as it does so below?

Philipp15b commented 3 years ago

Good catch! The function is definitely confusing. I think the original intent was to indicate by the Boolean whether listPath was used or not, not whether there was an error. I think that should be removed completely. Also, the result of s.bot.Client.Connect() (possibly an error) is completely ignored.

I would be happy to accept a pull request to fix that!