search

Philipp15b / go-steam

Steam's protocol in Go to allow automation of different actions on the Steam network without running an actual Steam client. Includes APIs for friends, chatting, trading, trade offers and TF2 crafting.
https://pkg.go.dev/github.com/Philipp15b/go-steam/v3
Other
387 stars 131 forks source link

Fix module paths - Fixes #115 #116

Closed Jleagle closed 3 years ago

Jleagle commented 3 years ago

I could remove all the dot import aliases too if you like as they are not recommended.

@gudvinr, could you check this over pease.

gudvinr commented 3 years ago

I don't think you're supposed to edit steamid/steamid.go since it doesn't have imports from github.com/Philipp15b/go-steam.
Since I'm not an author I can't say much but it looks pretty straightforward.

And I personally agree that dot imports must go. But it's a good idea to fill a different PR for that

Philipp15b commented 3 years ago

Thanks a bunch! I assume steamid.go had wrong line endings or why was the whole file changed?

I'll also happily accept another PR to remove dot imports. That might be a bit more difficult though as the generator must be adapted as well.

Jleagle commented 3 years ago

Yep, assumed it was line endings, let me know if you want me to revert the file.

gudvinr commented 3 years ago

Thanks a bunch! I assume steamid.go had wrong line endings or why was the whole file changed?

You can use .gitattributes or core.eol option for git and it'lll convert automatically.

Philipp15b commented 3 years ago

Thanks @Jleagle!