search

Philipp15b / go-steam

Steam's protocol in Go to allow automation of different actions on the Steam network without running an actual Steam client. Includes APIs for friends, chatting, trading, trade offers and TF2 crafting.
https://pkg.go.dev/github.com/Philipp15b/go-steam/v3
Other
392 stars 131 forks source link

Update generator for new protoc and protoc-gen-go #118 #120

Closed Tommy-42 closed 2 years ago

Tommy-42 commented 3 years ago

fixes https://github.com/Philipp15b/go-steam/issues/118

Hello,

this is my first PR on here, I never used go-steam yet, I wanted to but came across the issue #118

this was a tough one I didn't test yet, the generator generate the files without errors

Tommy-42 commented 3 years ago

Found out that I've a problem with import in generated pb.go

Tommy-42 commented 3 years ago

@Philipp15b

I've also bumped the version to v3 to avoid breaking backward compatibilities

Import are fixed I ran a go test ./... but it doesn't appears to contains that much tests sadly :/

I believe it is ready to be tested, if you have a working project using your project, would you mind testing this PR ?

Philipp15b commented 3 years ago

Again, thanks a lot for the hard work! I know this stuff is really tricky 👍

Jleagle commented 3 years ago

@Tommy-42 @Philipp15b Hey, is there anything left to do on this PR? Would be awesome to get it in. Thanks.

Philipp15b commented 3 years ago

If the retract stuff is removed altogether, I'm happy to merge this. I don't want to break uses of old versions.

Philipp15b commented 2 years ago

I merged this PR now, thanks a lot! I'm sorry for the long delay. I thought there was something left to do but GitHub still shows an outdated diff for me.