search

Philipp15b / go-steam

Steam's protocol in Go to allow automation of different actions on the Steam network without running an actual Steam client. Includes APIs for friends, chatting, trading, trade offers and TF2 crafting.
https://pkg.go.dev/github.com/Philipp15b/go-steam/v3
Other
392 stars 132 forks source link

Not handled results in handleLogOnResponse #54

Closed YellowOrWhite closed 9 years ago

YellowOrWhite commented 9 years ago

https://github.com/Philipp15b/go-steam/blob/ab14012226d16270cb5cfdd3615afae0ffa19519/auth.go#L111-L112

As code in the link shows, some results are explicitly not handled. My understanding is that this leads to a panic in readLoop. Why not emit FatalErrorEvent instead?

YellowOrWhite commented 9 years ago

Code works as intended. There is no panic in read loop.