Rework tradeoffer and economy, update inventory

Philipp15b / go-steam

Steam's protocol in Go to allow automation of different actions on the Steam network without running an actual Steam client. Includes APIs for friends, chatting, trading, trade offers and TF2 crafting.

https://pkg.go.dev/github.com/Philipp15b/go-steam/v3

Other

388 stars 131 forks source link

Rework tradeoffer and economy, update inventory #59

Closed YellowOrWhite closed 8 years ago

YellowOrWhite commented 8 years ago

Rework error handling, add SteamError type
Add GetOffer()
Change GetOffers() to accept params
Add retry methods to tradeoffer
Remove economy types, change to use uint64
Update economy/inventory structs
Update tradeoffer structs
Small fixes

This is not production ready. Interested in comments and feature requests.

Not sure about retry logic, maybe it would be better to implement it more generically by changing all methods to return only error and allowing to use WithReconnect(Method(param), retryCount, retryWait).

YellowOrWhite commented 8 years ago

Add GetPartnerEscrowDuration
Add GetOfferEscrowDuration
Add GetTradeReceipt
Add offerId param to GetPartnerInventory()
Add ToMap/Get methods to inventory collections
Add GetInventoryApps to inventory
Add GenericInventory type to inventory
Add TradeId to TradeOffer
Change tradeoffer AppId to uint32 for consistency
Rename GetTheirInventory to GetPartnerInventory
Rename TradeOffer IsOurs to IsOurOffer
Update trade offer states
Multiple fixes and small improvements

This may still be buggy, but a lot closer to ready state. For mobile auth/confirmations: https://github.com/YellowOrWhite/go-steam-mobileauth

Philipp15b commented 8 years ago

Better maybe buggy than not working at all. This looks very good. Extra :+1: for the retry stuff!