PhilippC / keepass2android

Password manager app for Android
https://play.google.com/store/apps/details?id=keepass2android.keepass2android
GNU General Public License v3.0
4.75k stars 382 forks source link

Argon2 runs out of memory #326

Open ghost opened 6 years ago

ghost commented 6 years ago

I have quite a bit of memory to spare, and would like to allocate 1GB+ memory in the Argon2 key derivation function, but the application warns me that I've run out of memory. I believe this can be overcome by setting android:largeHeap="true" in the manifest file.

PhilippC commented 6 years ago

android:largeHeap can have side effects - the app is more likely to be killed and that's definitely not what many users want when they use QuickUnlock. I think this only can be solved by implementing a plugin with android:largeHeap which does the key transform.

CrendKing commented 6 years ago

Sometimes when I choose to add the "KP2A_URL_1" property for an entry and KP2A saves the database I encounter the Out of memory error. My database uses Argon2. It happens only intermittently.