search

PhilippC / keepass2android

Password manager app for Android
https://play.google.com/store/apps/details?id=keepass2android.keepass2android
GNU General Public License v3.0
4.58k stars 378 forks source link

Crash when using fingerprint before OTP #754

Open PhilippC opened 5 years ago

PhilippC commented 5 years ago

when a database uses OTP Key provider, the app crashes when fingerprint is used before OTPs are entered.

PhilippC commented 4 years ago

seems fixed since 1.08

Jaaaaanobert commented 2 years ago

Hi,

The bug unfortunately still exists and was not fixed with version 1.08.

Scenario: Database is already selected. I start the app, KeePass asks for my fingerprint. After pressing the fingerprint, the app crashes.

Second try: I start the app and tap the "back" button of my phone to avoid pressing the fingerprint. I manually press the field to read my YubiKey now and read it via NFC. After reading the YubiKey. I manually press the fingerprint symbol next to the password-field and press the shown "unlock with fingerprint"-field to unlock the database. The database opens without any issues or crashes.

The database is synced via ftp from a local NAS-Server and is accesses by Windows-Computers.
I am using a YubiKey 5 NFC and the plugin "KeeChallenge" on the Windows machine to unlock the databases.

Tested this on several devices with several databases (all stored on ftp-server) on android 10 and 11. I am using the newest KeePass version in the PlayStore (1.09c-r0). The bug was never fixed since opening this issue.

pmorange commented 2 years ago

Hi, The issue is not fixed. Same as #1151 indeed.

Hope to see this fixed someday, but the issue has been present for so long that I don't know if I should still hope or make my peace with the issue...

Cheers.

alexander-thiesen commented 1 month ago

Hi, the issue is still not fixed. The only way it works is like described by @klausklemens in https://github.com/PhilippC/keepass2android/issues/1151#issuecomment-901753840_ "I always have to abort fingerprint reading, load otp auxilary file, and finally press the fingerprint button next to the password field and it works."

I wanted to try to fix the issue myself, but unfortunately, since I am inexperienced, I was unsuccessful to build keepass2android on my PC. My idea to solve the issue was just to disable fingerprint until the otp file was loaded and then prompt for fingerprint. Or disable automatic unlocking when the fingerprint is inserted when no otp file has been loaded.

Cheers.