PhilippC / kp2a_accservice_autofill

Accessibility service based AutoFill plugin for Keepass2Android
GNU General Public License v3.0
155 stars 20 forks source link

Add support for brave browser #11

Open kaivol opened 6 years ago

kaivol commented 6 years ago

Hey,

Brave Browser seems to be very similar to Chrome and autofill already works, but the URLs won't get recognized (only "androidapp://com.brave.browser"). Maybe a check for the URL bar similar to the way it's done for Chrome would be enough to make it work:

if ( "com.brave.browser".equals(root.getPackageName()) )
{
    List<AccessibilityNodeInfo> urlFields = root.findAccessibilityNodeInfosByViewId("com.brave.browser:id/url_bar");
    url = urlFromAddressFields(urlFields, url);
}

Would be wonderful if you could look into this.

tpaulshippy commented 6 years ago

Hi @PhilippC, Thank you for this great app and service - I use them every day. I have also started using the Brave browser on Android recently and I have tested the code @KaiDevelopment suggested on a local (somewhat hacked java-only) copy of the autofill service and it did seem to properly find the URL and pass it along. If you could add these 5 lines of code to the next release, I would be grateful!

staticn0de commented 5 years ago

Hi @PhilippC, just a quick note to let you know this is still a desired addition to the plugin. Thanks for all the work you have done, I use it every day.

nicolaspernoud commented 5 years ago

I really would like to be able to use it with brave ! Thanks for this amazing software by the way.

kaivol commented 5 years ago

Hi @PhilippC, Thank you for this great app and service - I use them every day. I have also started using the Brave browser on Android recently and I have tested the code @KaiDevelopment suggested on a local (somewhat hacked java-only) copy of the autofill service and it did seem to properly find the URL and pass it along. If you could add these 5 lines of code to the next release, I would be grateful!

I would be very helpful if you could publish your version of the autofill service or at least give some information about how you created your modified version. I tried to do this myself but can't get it right as can't find any documentation on how to develop plugins for KP2A.