PhilippHeuer / wordpress-heroku

This project is a template for installing and running WordPress 5.x on Heroku.
MIT License
273 stars 316 forks source link

Why use memcached and redis-cache plugins at the same time? Why use Nginx Helper? #11

Open etherealite opened 7 years ago

etherealite commented 7 years ago

Really loving this roots.io based boilerplate.

Description of your issue

It's pretty much all in the title. Why use memcached (batcache) when the redis cache plugin is already in use. Redis is faster than memcached now anyways. I'm starting to think that maybe batcache can be configured to work with the Redis object cache or something? Seems a little confusing to me since it's advertised as a memcache plugin.

I don't understand why you've included Nginx Helper since it's primary concern is cache invalidation which heroku nginx doesn't even support. The stuff that it brings to the table for multisite rewrite is trivial to replicate, so why bother with it? Does it invalidate the same object cache that batcache is using?

Steps to Reproduce

None

Other Information

Git Commit/Version: current master

sebbean commented 6 years ago

@etherealite ever get anywhere with this? i'm using this as a base for my workflow - curious if i can remove either one of those safely. guess i can try it out

etherealite commented 6 years ago

Hey @sebbean,

I'm sorry, but we ended up scrapping heroku as our hosting platform for the time being, thus I never looked into this any further.

If i'm remembering correctly, the redis caching plugin requires batcache to work, so that isn't a problem.

When it comes to Nginx Helper, I vaguely remember removing it and stuff appeared to work fine on my non-multisite WP instance.