PhilippHeuer / wordpress-heroku

This project is a template for installing and running WordPress 5.x on Heroku.
MIT License
273 stars 316 forks source link

Some key can't parse correctly AWS_S3_URL #26

Closed naoa closed 6 years ago

naoa commented 6 years ago

Description of your issue

You are using parse_url function to parse AWS_S3 options.

https://github.com/PhilippHeuer/wordpress-heroku/blob/master/config/plugins/wordpress/wordpress-s3uploads.php#L7

But it can't parse correctly some key included "\n".

Steps to Reproduce

For example, the following string can't parse_url correctly.

<?php
  $env = "s3://hoge:hoge/nhoge@s3-us-west-2.amazonaws.com/backetName";
  var_dump(parse_url($env));
?>

Other Information

Git Commit/Version: 564770e29c4182a02690b2347b9e27bb7cb4b9f8

PhilippHeuer commented 6 years ago

Hey, thanks for contributing 👍

I guess i was just lucky with my keys.