PhilippImhof / moodle-quiz_essaydownload

Quiz report plugin for the Moodle LMS, allowing to bulk download student responses and attachments to essay questions
0 stars 0 forks source link

The Zip Archieve File Corrupt when Extracted #5

Closed suryodanar closed 1 month ago

suryodanar commented 1 month ago

Thank You Phillipp for this amazing plugin on moodle. I have a problem when using it, after i submit the download button Screenshot (373)

i have file in zip but when i try to extract the file it goes corrupt like this Screenshot (374)

Is there any possible way to fix this problem ?

Thank You, Regards

PhilippImhof commented 1 month ago

Thanks for reaching out. I am sorry you have problems using the plugin. A few questions, trying to figure out what happened:

PhilippImhof commented 1 month ago

Thank you for your fast response, I'll try to answer it

  1. There's no one extracted file works fine
  2. Just 1 Essay Question
  3. Real Quiz for Remedial MidTerm Exam at My Campus
  4. I will share it a few of them below

Thanks. I will have a look and try to figure out what happens. Also, I will delete your last post to remove the files, just in case.

suryodanar commented 1 month ago

thanks in advance for your help @PhilippImhof

PhilippImhof commented 1 month ago

Another question popping up: Do you have any customisations, e.g. a special theme or anything?

PhilippImhof commented 1 month ago

Trying not to disclose too much, but can you confirm that for the quiz "Ujian_Tengah_Semester_PA_Budha", there are supposed to be 15 students:

The data is there, but the ZIP file also contains a HTML error page generated by Moodle, so I am trying to find out where that error occurs. (It does not on my testing servers.)

PhilippImhof commented 1 month ago

@suryodanar I don't know how comfortable you are with all this stuff, but would you mind trying to install the version from the fixcorruption branch and check whether the problem is resolved with that?

I cannot test it myself, because the error does not occur on my systems.

suryodanar commented 1 month ago

Trying not to disclose too much, but can you confirm that for the quiz "Ujian_Tengah_Semester_PA_Budha", there are supposed to be 15 students:

  • Ang. Agn.
  • Dar. Sub.
  • Fra. Ang.
  • Lav. Glo.
  • Mig. Vel.
  • Mo. Wij. Lyd.
  • Mo. Wij. Liv.
  • Sam. Suw. Kan.
  • Seb Rai. Ric.
  • Sub. Sam.
  • Sur. Tri.
  • Tan. Yol.
  • Van. Ven.
  • Wil. Nat.
  • Win. Fin.

The data is there, but the ZIP file also contains a HTML error page generated by Moodle, so I am trying to find out where that error occurs. (It does not on my testing servers.)

Yeah it's right there's 15 students, but for Mo. Wij. Lyd. & Mo. Wij. Liv. both of them didn't submit the quiz but using text response on moodle

PhilippImhof commented 1 month ago

Thanks for the confirmation. So all data is there and the ZIP is correctly prepared, it gets corrupted later in the process. The proposed fix should probably solve the issue.

suryodanar commented 1 month ago

@suryodanar I don't know how comfortable you are with all this stuff, but would you mind trying to install the version from the fixcorruption branch and check whether the problem is resolved with that?

I cannot test it myself, because the error does not occur on my systems.

Thank you, of course I will. Hope the problem can be resolved after this

suryodanar commented 1 month ago

Hi, Thanks in advance @PhilippImhof I just want to share information, about your version from the fixcorruption branch already fix my problem until i try to know more and more and the problem still happen like this zip files https://drive.google.com/file/d/19-LLYjp2AGCNVec9xWrq2xHY3mV2_Q6U/view?usp=sharing (I can attatch direct from this so uses googledrive) I've check randomly and still found error for the large file and long path name of zip file

PhilippImhof commented 1 month ago

Thanks very much for your efforts and report. Checking your second ZIP files showed me another issue that should be fixed in the other branch. So if you have some time, I would appreciate if you could test it again.

PhilippImhof commented 1 month ago

@suryodanar I have merged the PR. Please try the latest version from the main branch. It fixes the issue of corrupted ZIP archives and also includes better error reporting so we can track down other issues, if there are any.

Thanks very much for your help. Once I hear back from you (with a hopefully positive feedback), I will prepare and publish a new release.

suryodanar commented 1 month ago

thank you @PhilippImhof, I really love to try it again. Really grateful with your effort . Soon I'll report the result to you.

suryodanar commented 1 month ago

and one more request if possible, usually in campus username for student is the student id number, when teacher / lecturer download the eassay submission, compare with the last plugin we used is easier to identify when put the username as the first folder's name than lastname / firstname of students.

here's the example of the download zip file from that plugin https://drive.google.com/file/d/1wbAQ44iVbAD7V5Jd6WRk79Iu6kdKaXzO/view?usp=sharing

suryodanar commented 1 month ago

I've been test to download again, in first try get this error message image in one of the file Error0x80010135: Path too long

PhilippImhof commented 1 month ago

Thanks for testing it again. That last issue is a known Windows problem.

I will open a separate issue for that and try to add some option. And I'll open another issue to add an option where the user can select the name ordering as First/Last or Last/First.

I am now closing this issue as solved, thanks again for your help while debugging. Feel free to comment again or to add comments to the two new issues.

PhilippImhof commented 1 month ago

Fixed with PR #6

PhilippImhof commented 2 weeks ago

@suryodanar Just to let you know that I am currently preparing version 1.1.0 for a release later today. It will include an option that lets you choose between First/Last or Last/First name ordering.