search

PhilippStein / ng2-ion-range-slider

Ion Range Slider for Angular https://github.com/IonDen/ion.rangeSlider
MIT License
35 stars 39 forks source link

Fixed function name typo. Suppose that 'restore' means 'reset' #11

Closed novitskiy-aleksei closed 6 years ago

novitskiy-aleksei commented 7 years ago

Because there is no such method in base lib: https://github.com/IonDen/ion.rangeSlider#public-methods

and for me it caused error: ERROR TypeError: jQuery(...).data(...).restore is not a function

novitskiy-aleksei commented 7 years ago

Found related issue: #10 Philipp, where are you? :) Merge please

PhilippStein commented 7 years ago

Hi @novitskiy-aleksei, sorry for the late response and thanks for your pull-request. If the ionrangeslider method is named reset instead of restore I think the components function name should be renamed the same way. https://github.com/novitskiy-aleksei/ng2-ion-range-slider/blob/2ca8bf35d4fc40474f36199d0edcf1f17f91f82c/src/ion-range-slider.component.ts#L89. Can you please rename that as well, than I will accept the pull-request.

Thanks, Philipp