Fix use of kernel functions unavailable starting with v5.18

PhilippeBekaert / snd-hdspe

New linux driver and tools for RME HDSPe sound cards and extension modules

GNU General Public License v3.0

51 stars 18 forks source link

Fix use of kernel functions unavailable starting with v5.18 #12

Open Schroedingers-Cat opened 2 years ago

Schroedingers-Cat commented 2 years ago

This PR adds support for Linux Kernel v5.18 and higher which removed two deprecated functions.

I tested this with a HDSPe MADI on kernel versions 5.17, 5.18 and 5.19 on Manjaro.

VennStone commented 2 years ago

Works on the AIO Pro with 5.18.

wolframd commented 1 year ago

Hello LGCW, which distro and desktop are you using? Compilation fails with me and kernel 5.19.0-26 as well. If your distro works fine with it, I consider changing (it's ubuntucinnamon now). Since the developer passed away quite young, I see no other way for me... Thanks! HDSPE Compilation fails with 5.19.txt

Schroedingers-Cat commented 1 year ago

Do you have the kernel headers installed?

wolframd commented 1 year ago

Thanks for responding so fast! Sure, I followed the yt video by the book since instructions on github are a bit sparse.

05.01.2023 20:07:49 Schroedingers-Cat @.***>:

Do you have the kernel headers installed?

— Reply to this email directly, view it on GitHub[https://github.com/PhilippeBekaert/snd-hdspe/pull/12#issuecomment-1372620577], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AOBWQMK43Q4NKSR4Q4EUGTLWQ4LYFANCNFSM55YNKTIQ]. You are receiving this because you commented.[Verfolgungsbild][https://github.com/notifications/beacon/AOBWQMI7D5WSWZPZN74ZOULWQ4LYFA5CNFSM55YNKTI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOKHIIOII.gif]

Schroedingers-Cat commented 1 year ago

If you have those installed, can you double check that you've checked out my fork with the support-v5.18 branch? The code that fixes the compile issue isn't part of this repo.

wolframd commented 1 year ago

Oh, I think I was a bit blind and didn't realize you committed a patch. Great! Will try tomorrow and be back than. Thanks!

wolframd commented 1 year ago

Sorry, I was too busy the last weeks. I went back to kernel 5.15. SMP PREEMPT. So far many things work well - but ;-) SPDIF (both optical and coaxial) only transmits one channel. May it be the reason is alsamixer sending all channels as mono only? Analog is noisy, every change on my display generates some noise (AMD Radeon HD Baffin).

jimfrench commented 1 year ago

Confirmed working on 6.2.9-060209-generic #202303301133 SMP PREEMPT_DYNAMIC

Aside from index out of bounds error in hdspe_mixer.c (that was there before, doesn't seems to be stopping the mixer util from working, or the card)

Card is HDSPe AES

Analogue noise / interference, doesn;t sound like a driver issue to me? Maybe try card in different machine

snd_hdspe_log.txt