PhilippeBoisney / AlertOnboarding

A simple and attractive AlertView to onboard your users in your amazing world.
MIT License
842 stars 109 forks source link

Swift 3 Support #12

Closed mattmcneeney closed 7 years ago

mattmcneeney commented 7 years ago

Are there plans to upgrade this library to support Swift 3? Thanks!

PhilippeBoisney commented 7 years ago

Hey ! Update is done and works great, but integration with Cocoapod seems to be not ready for Swift 3.0. However, you can find the update for swift 3.0 here : https://github.com/PhilippeBoisney/AlertOnboarding/tree/swift-3.0 Or a temp quick is to link your Cocoapod with the github branch:

target 'MyApp' do
    pod 'AlertOnboarding', :git => 'https://github.com/PhilippeBoisney/AlertOnboarding', :branch => 'swift-3.0'
end

Just let me know if it works :)

PhilippeBoisney commented 7 years ago

Mhhhh ok, it seems to work with a little hack... Just update your Cocoapod now :)

Dreamersoul commented 7 years ago

for some reason xcode still thinks that version 1.8 is swift 2.3 even when doing this.

pod 'AlertOnboarding', :git => 'https://github.com/PhilippeBoisney/AlertOnboarding', :branch => 'master'
mattmcneeney commented 7 years ago

@Dreamersoul Same issue here - tried that last Wednesday and again today but still no luck.

Dreamersoul commented 7 years ago

@mattmcneeney that's weird, could @PhilippeBoisney try using pods and perhaps tells us what's wrong?

PhilippeBoisney commented 7 years ago

I've just re-created a new release (1.9). Can you update your podfile please ? pod update Then, before building your app, just clear your Derived Datas folder, otherwise it will keep release 1.8 to build your app. Let me know if it works (I've just tried with new sample project, and everything seems good)

mattmcneeney commented 7 years ago

@PhilippeBoisney Version 1.9 has now checked out! Many thanks

PhilippeBoisney commented 7 years ago

No problem 👍 Have a fun !