search

PhilippeBoisney / ArchApp

Simple Android app to show how to design a multi-modules MVVM Android app (fully tested)
624 stars 97 forks source link

koin 2.0 support #4

Open victory1908 opened 5 years ago

victory1908 commented 5 years ago

Hi have u tried upgrade to koin 2.0. Seem like compile ok but does not work, always error no definition for viewmodel when install

matghazaryan commented 4 years ago

Hey Victory1908 did you manage to run it with Koin 2?

hamedsilver commented 4 years ago

@PhilippeBoisney I update to Koin 2 on my pull request you can check it :) and I also update the libraries , and some small changes https://github.com/PhilippeBoisney/ArchApp/pull/7

matghazaryan commented 4 years ago

@hamedsilver thank you for your efforts. One question how can I make User class parcelable? RIght now I can make it only Serializable.

hamedsilver commented 4 years ago

@matghazaryan why do you want to parcelable User class? "Model" module is a kotlin module and not android module , if you want to pass user class by navigation to your destination you can map it to another class and you can put it in navigation module like this: @Parcelize data class UserArgs( val id: String?, val login: String?, val name: String?, ... ) : Parcelable