PhilippeChab / nwscript-ee-language-server

A NWScript Language Server.
https://marketplace.visualstudio.com/items?itemName=PhilippeChab.nwscript-ee-language-server
MIT License
20 stars 7 forks source link

TextMate Grammar Does not Parse Correctly on 1.86 #67

Closed tinygiant98 closed 9 months ago

tinygiant98 commented 9 months ago

Type: Bug

  1. Use the extension under 1.86

The noted extension (nwscript-ee-language-server) is a language server implementation for a custom language that relies on a textMate grammar. Under 1.85 and all previous versions of vsCode, this textmate grammar parses correctly and the language server reliably provided the product it is desgined to supply.

When vscode updated to 1.86, the textmate grammar no longer reliable parses and always errors on a line including </dict>, though the actual grammar component it errors out on varies considerably. This, and the fact that it worked reliably until 1.86, leads me to believe there was a base code change that caused the issue, not the grammar itself, since the grammar hasn't changed in years. Multiple members of our development team have noted the same behavior on 1.86. Reverting to 1.85 fixed the issue.

Extension version: 2.1.0 VS Code version: Code 1.85.2 (8b3775030ed1a69b13e4f4c628c612102e30a681, 2024-01-18T06:40:10.514Z) OS version: Windows_NT x64 10.0.19045 Modes:

A/B Experiments ``` vsliv368cf:30146710 vspor879:30202332 vspor708:30202333 vspor363:30204092 vstes627:30244334 vscod805cf:30301675 binariesv615:30325510 vsaa593:30376534 py29gd2263:30899288 vscaac:30438847 c4g48928:30535728 azure-dev_surveyone:30548225 a9j8j154:30646983 962ge761:30951796 pythongtdpath:30769146 welcomedialogc:30910334 pythonidxpt:30866567 pythonnoceb:30805159 asynctok:30898717 pythontestfixt:30902429 pythonregdiag2:30936856 pyreplss1:30897532 pythonmypyd1:30879173 pythoncet0:30885854 pythontbext0:30879054 dsvsc016:30899300 dsvsc017:30899301 dsvsc018:30899302 dsvsc019bcf:30953938 7j2b6412:30949929 e3gdj431:30956216 ```