PhilippeKr / TorchLight

Slightly enhanced Torch and Light Module for Foundry VTT, based on the excellent work of RealDeuce on the Torch Module.
4 stars 18 forks source link

Cannot turn off lights. #29

Closed FrozenSCV closed 3 years ago

FrozenSCV commented 3 years ago

When trying to turn of a light it gives the following error Tokendata light color "16777215" is not a valid hexadecimal color string.

This happens when trying to turn off any light. It will properly switch lights if other lights are clicked, but will not remove them.

vanderleitelesjr commented 3 years ago

Probably an incompatibility with the light system changes of 0.8.x, I just updated to the new stable version (0.8.6) and started to experience the same issue. Also when turning on the light the brightness is way to high in the player view (brightness seems normal on GM side though).

lukejpreston commented 3 years ago

I am seeing this as well on the stable version of 0.8.x in Foundry

CommanderAlex98 commented 3 years ago

Same her after update to 0.8.x. Pls fix. It is a nice module.

Verdemis commented 3 years ago

I have the same problem too. Is this module still supported? I hope so, it's great.

PhilippeKr commented 3 years ago

Hi, Unfortunately, while I wanted to experiment with the development within foundry and had some available leisure at that point in time, it is no longer the case. Moreover, I did not foreseen the amount of requests to expand the module. I have tried to follow up at start, but it has become quite bloated and therefore difficult in particular to test. Neither did I foreseen that a change of version in Foundry would require me to update the module, especially when the documentation about the update is not that precise. So I'm sorry, but I won't be able to maintain the module anymore, if anyone wants to take it over, it will be with my full blessing.

Verdemis commented 3 years ago

That's absolut understandable. Maybe I will have a look at it in the next days.

cs96and commented 3 years ago

I might be willing to get this in a working state for 0.8.x, but not to take on full ownership or add support for any outstanding feature requests.

@PhilippeKr, would you be willing to do a release if I submitted a pull request with 0.8.x fixes?

PhilippeKr commented 3 years ago

This is a great offer, thanks, as there are quite a few people requesting it here and on GitHub. The only thing I must confess is that I'm really a noob at all that, it was mostly a project to keep some of my skills from degrading. So no worries about doing the release, but you might have to take me through it step by step though.

Alternatively, I'm not using GitHub for anything else than this project, so I will gladly give you my user/password if you want to maintain it here, or if you just need them for the final release, let me know.

cs96and commented 3 years ago

So no worries about doing the release, but you might have to take me through it step by step though.

I'm slightly confused by this statement, as you have already made several releases, so you must know how to do them already!

PhilippeKr commented 3 years ago

I did them, but in a simple way, straightforward and without taking in pull requests, and so on, that's all. And that was a few months ago, so I might need some refreshing. I have quite a bit of development behind me, but most of it was a long time ago professionally, so I have a few reflexes, but I get lost fairly quickly in the intricacies of GitHub.

cs96and commented 3 years ago

The pull request part is easy. Once you are happy with it you just accept it and merge in the changes. Then you just do the release like you normally would. I'm not sure how you built your previous releases though, so I can't help you with that.

PhilippeKr commented 3 years ago

That's fine, I'm sure I'll be able to figure it out again.

cs96and commented 3 years ago

Pull request submitted

PhilippeKr commented 3 years ago

Thanks, I'm trying to shake the rust from all that, working on it this weekend to get it back into the official modules, I'll let you know when I'm done.