PhilippeKr / TorchLight

Slightly enhanced Torch and Light Module for Foundry VTT, based on the excellent work of RealDeuce on the Torch Module.
4 stars 18 forks source link

Update 9.X - Bug #41

Open marcottedan opened 2 years ago

marcottedan commented 2 years ago

Module now throws this error when you light a torch:

torchlight.js:380 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'type')
[Detected 1 package: torchlight]
    at storeTokenLighting (torchlight.js:380)
    at onButtonClick (torchlight.js:205)
coffiarts commented 2 years ago

Same for me. None of the lights switch on or off in v9.

PhluXx1 commented 2 years ago

@marcottedan @coffiarts Guys I hate to tell you but this project is effectively abandoned. The only reason it even received a 0.8.x update was due to a pull request. Unless someone else provides a v9 update I wouldn't expect to see one.

coffiarts commented 2 years ago

Good to know, thanks for the update anyway. I appreciate your efforts. Still, this add-on is/was a really cute thing! I'd be delighted to see some hero pick it up again :)

PhluXx1 commented 2 years ago

@coffiarts I'm not the dev just a fan and yeah it sucks because I love the module hopefully someone takes it over.

Malekal4699 commented 2 years ago

Alright, I did not make a Pull request as the last 2 were not processed. So I forked and updated to v9.

You can grab it here:

https://github.com/Malekal4699/TorchLight/releases/latest/download/module.json

Have fun :)

PhluXx1 commented 2 years ago

Alright, I did not make a Pull request as the last 2 were not processed. So I forked and updated to v9.

You can grab it here:

https://github.com/Malekal4699/TorchLight/releases/latest/download/module.json

Have fun :)

Thanks bro you're the real MVP.

@Malekal4699 May not be a bad idea to for you to make a post about this update on the Foundry subreddit to get the word out to people.

coffiarts commented 2 years ago

@Malekal4699 - Now YOU are our hero! Checked your version out, and from a brief test it seems to work like charm! Took me a bit of a brain to figure out how to install your update over PhillippeKr's original, as your directory structure differs from his. Took me a couple of minutes to understand that I need to completely replace any files under ...\data\mdules\torchlight with yours. Thanks a thousand times!!

Malekal4699 commented 2 years ago

@Malekal4699 - Now YOU are our hero!

Checked your version out, and from a brief test it seems to work like charm!

Took me a bit of a brain to figure out how to install your update over PhillippeKr's original, as your directory structure differs from his. Took me a couple of minutes to understand that I need to completely replace any files under ...\data\mdules\torchlight with yours.

Thanks a thousand times!!

It's usually a good idea, when having issue after an update, to simply uninstall the module and reinstall with the new manifest url

coffiarts commented 2 years ago

It's usually a good idea, when having issue after an update, to simply uninstall the module and reinstall with the new manifest url

But this is the thing I didn't get (probably out of my stupidity): I can't find a valid manifest url on your github page at https://github.com/Malekal4699/TorchLight. That's why I had to fumble around manually. Did I just miss it?

PhluXx1 commented 2 years ago

https://github.com/Malekal4699/TorchLight/releases/latest/download/module.json

@coffiarts You could just take the URL he provided above and just paste it into the Manifest URL option at the bottom of the Install Module installer in Foundry then click install (see screenshot below).

image

Malekal4699 commented 2 years ago

Like @PhluXx1 said. I'll pick the module up, so the Foundry should soon point at the right place.

PhluXx1 commented 2 years ago

I'll pick the module up, so the Foundry should soon point at the right place.

@Malekal4699 The news just gets better and better. If I could recommend a name change to "LampLight" or something like that to differentiate and to keep with the tradition of take overs. Thank you for your service.

salutegif

Malekal4699 commented 2 years ago

HeaUDLight?

PhluXx1 commented 2 years ago

HeaUDLight

You mind elaborating on this name?

Malekal4699 commented 2 years ago

Headlight, Plus HUD, Head's up display which is the main functionality of the mod lol

Malekal4699 commented 2 years ago

HeUaDLight

PhluXx1 commented 2 years ago

Headlight, Plus HUD, Head's up display which is the main functionality of the mod lol HeUaDLight

@Malekal4699 Name it whatever you're happiest with, personally I think HUDLight sounds better

coffiarts commented 2 years ago

https://github.com/Malekal4699/TorchLight/releases/latest/download/module.json

@coffiarts You could just take the URL he provided above and just paste it into the Manifest URL option at the bottom of the Install Module installer in Foundry then click install (see screenshot below).

image

@PhluXx1 - Yeah, that worked. Somehow I was sitting on my eyes. Thanks again! :)

dczwardCZAR commented 2 years ago

OMG, thank you for fixing this for v9. I've been wanting to use this for a long time ever since in broke back in v8.? . But this would be fantastic if it could consume a torch inventory item.

Malekal4699 commented 2 years ago

OMG, thank you for fixing this for v9. I've been wanting to use this for a long time ever since in broke back in v8.? . But this would be fantastic if it could consume a torch inventory item.

Hi, please add an issue in the new repo so I don't forget!

Thanks!

jpmiers commented 2 years ago

Alright, I did not make a Pull request as the last 2 were not processed. So I forked and updated to v9.

You can grab it here:

https://github.com/Malekal4699/TorchLight/releases/latest/download/module.json

Have fun :)

Hello, I've installed this fork and it seems that the mod is enabling debug mode in the console. Is there any way to turn it off? It's spitting out messages anytime I click or move the mouse. Lots of clutter. I verified that its this mod by disabling it and reenabling it.

PhluXx1 commented 2 years ago

@jpmiers Open up a new issue on the github page https://github.com/Malekal4699/LightsHUD/