search

Philippus / elastic4s

🔍 Elasticsearch Scala Client - Reactive, Non Blocking, Type Safe, HTTP Client
Apache License 2.0
1.64k stars 695 forks source link

releases 7.17.3 and 7.17.4 use elasticsearch 8 #3187

Closed OriHoch closed 3 weeks ago

OriHoch commented 1 month ago

seems like both 7.17.3 and 7.17.4 were released from incorrect branch that supports elasticsearch 8

v7.17.4 is identical to release/8.3.x:

https://github.com/Philippus/elastic4s/compare/v7.17.4...release/8.3.x

Philippus commented 1 month ago

Are there features you're missing in 7.17.2 ?

OriHoch commented 1 month ago

Hi, thanks for the quick response. No, I will use 7.17.2

I'm just upgrading a large legacy project's dependencies and did a lot of work to adapt for API changes only to realize later that it uses the wrong ES version. I only realized it because there is usage of Common Terms Query which was removed in 8.. I guess if it weren't used I might not have noticed it and maybe encountered harder to track problems later..

OriHoch commented 1 month ago

I guess the issue is due to the manual github workflow? I'm happy to implement a more automated github workflow for you to prevent such problems if you want or add some validations etc..

Philippus commented 1 month ago

7.17.3 and 7.17.4 releases were released before the current workflows. When I have some time I'll see if I can create one last proper version for Elasticsearch 7.17.x. Don't want to spend too much time on it though. Elasticsearch 8 has been out for a long time.

Philippus commented 3 weeks ago

I've released a new version 7.17.25-RC1. Can you try it out? It's under the new groupId, e.g.: libraryDependencies += "nl.gn0s1s" %% "elastic4s-client-esjava" % "7.17.25-RC1". It's based off this branch: https://github.com/Philippus/elastic4s/commits/series/7.x/ and should be identical to version 7.17.2, except for a bunch of dependency updates.

OriHoch commented 3 weeks ago

thanks, yes I tested it, it's good

Philippus commented 3 weeks ago

7.17.25 has been released.