PhilippvK / playforia-minigolf

Client & Server for Minigolf Game known from Playforia/Playray/Appeli. Written in Java.
85 stars 31 forks source link

Bundle maps into build artifacts #104

Closed StenAL closed 11 months ago

StenAL commented 1 year ago

Description

With this change, the server no longer needs to be deployed alongside a tracks directory and the symlink to the tracks directory can also be removed, making the server work without any changes on Windows.

Tracks are now bundled into the jar file generated by mvn package, however the location where tracks are searched for can still be overridden with a CLI flag.

This required changing the way FileSystemStatsManager and FileSystemTrackManager load tracks by making it possible to configure which kind of file system they should use as jar resources can only be read as files when using a bespoke FileSystem.

Also a bunch of duplicate unused assets have been removed. See individual commits for more details.

Testing

PhilippvK commented 1 year ago

@pehala FIY

StenAL commented 1 year ago

Changes since last review:

PhilippvK commented 1 year ago

Look fine for me. If I receive no complaints until Monday this gets merged!