issues
search
PhilippvK
/
playforia-minigolf
Client & Server for Minigolf Game known from Playforia/Playray/Appeli. Written in Java.
84
stars
31
forks
source link
More client code quality improvements, removing more unused assets
#116
Closed
StenAL
closed
3 weeks ago
StenAL
commented
3 weeks ago
This PR contains a bunch of cleanup but no functional changes:
NOP is renamed to number of players, without deep context it is not obvious what the (R)NOP classes were doing
Static initializer blocks were removed in favor of initializing static fields in their declarations
A bunch of unused assets were removed, mostly related to AGolf2 but also some old server code relics and assets from other games
A bunch of small code quality improvements:
Use integers instead of chars in math operations
Use more magic constants where possible
Remove more unused imports
Remove useless JavaDocs that just say "Playforia"
Remove some explicit uses of UTF-8 enconding. This is the default encoding since Java 18.
Remove unused LobbyRef class
This PR contains a bunch of cleanup but no functional changes: