Merge phibo22

[PhilippvK]

I have reimplemented the changes by myself, because I did not really like the Colors and I wanted to keep the Code for the Dual Game Mode for later use.

Main changes:

• Removed Dual Player Mode from UI
• Increased Limit of Players per Game to 10 (Adding more ball+player colors)

[PhilippvK]

@pehala @flying-aces-hb I have 2 questions regarding the 10 Player Limit and I would be happy to hear your feedback:

1. We need some mechanism to ensure the compatibility of Clients and the Server. (Imagine Joining a Game with >4 Players with an old Client JAR) I would like to keep it as simple as possible.
2. To fit the additional Player-Scores on the Screen, the Window Height had to be increased and the additional offsets makes the Menu/Lobby Layout look quite bad. Any recommendations on how to solve this? (Changing Window Height only when inside a Game Session?)

[pehala]

I would maybe consider rewriting the server/client part because in this state we cannot easily add new features and it was written as an emergency.

If we decide to go this path, we don't have to deal with the version right now and deal with it in the rewrite PR.

I didn't check the UI yet, so I will do that later.

[flying-aces-hb]

Thanks! Will build and test this with the guys, then I'll let you know about our feedback.

[PhilippvK]

Any opinions regarding the lobby layout?

[flying-aces-hb]

Sorry for the late feedback, it's working and we have nothing to complain about. :D

One possible bug that was reported was that maps with multiple spawns do not work with 5+ players, I have not been able to test this myself yet.

[pehala]

Based on the client code and how messy it is, I would say that the bug is very plausible. I would also say that it sadly will not be an easy fix, so we can either wait with this MR to polish this and rewrite part of the client or we can release this as a very experimental feature and fix it later. @PhilippvK @flying-aces-hb WDYT?

[flying-aces-hb]

For us it would be fine to wait with this MR and release it later.

[PhilippvK]

Thank you both for your feedback!

Regarding the payer limit increase as an experimental feature I have nothing against releasing it as long as normal matches are not affected by the aforementioned bugs.

The other question was the layout of the client which is definitely even worse with this MR. I had the idea to implement window resizing and full screen mode for the client which would probably solve the "problem" on the fly. However I have no idea how hard this is to implement...

[pehala]

You can do a Proof of Concept and then we can decide, but my guess is that it is gonna be nightmare as the GUI classes are decompiled without proper names.

[PhilippvK]

Let's see! It is not high on my priority list.

it is gonna be nightmare as the GUI classes are decompiled without proper names.

Magic Variables! I am tutoring an Embedded Systems Programming Lab and half of the students are using them all over the place 😂

[PhilippvK]

Okay, I will close this mainly because auf the following reasons:

• 4+ Players is even more challenging than I thought. Apart from windows size and finding suitable colors which are solvable problems, afaik there exists Maps with up to 4 different spawn points which would not work properly with more than 4 players
• The Dual Player is in fact noch required and there is a lot of dead code related to it but i would prefer to keep it, especially because I am going to create an Enumeration for the game type and the IDs SINGLE(1), DUAL(2), MULTI(3) are easier to understand than SINGLE(1), MULTI(2)...