PhilippvK / playforia-minigolf

Client & Server for Minigolf Game known from Playforia/Playray/Appeli. Written in Java.
84 stars 31 forks source link

Rewrite Release workflow to get rid of `set-env` command #82

Open PhilippvK opened 3 years ago

PhilippvK commented 3 years ago

Recent release had the following issue:

Unable to process command '::set-env name=VERSION::2.1.1.0-BETA' successfully.
---
The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

Further details: https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#stopping-and-starting-workflow-commands

PhilippvK commented 3 years ago

Quick workaround for now:

ACTIONS_ALLOW_UNSECURE_COMMANDS: true

@pehala Are you interested in using Environment files instead of set-env for performing the same job?

pehala commented 3 years ago

Sure we can try that. https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#environment-files

PhilippvK commented 3 years ago

ACTIONS_ALLOW_UNSECURE_COMMANDS: true works fine for me and does not need to be replaced.

pehala commented 3 years ago

We can use it at least temporarily, but it is deprecated and probably will be removed in the future. I suggest we leave the issue open (or create a new one) if we decide to go that round so we don't forget to rewrite it.