search

PhilippvK / playforia-minigolf

Client & Server for Minigolf Game known from Playforia/Playray/Appeli. Written in Java.
85 stars 31 forks source link

Rename some magic variables #85

Closed Nokkasiili closed 3 years ago

Nokkasiili commented 3 years ago

Did this for my own project :monkey:

PhilippvK commented 3 years ago

Thank you very much. This really helps to make the code more readable.

Off-topic: I am aware of your reimplementation-efforts and follow the progress regularly. I am also very impressed of your work and would like to mention https://github.com/eioo/minigolf in this Repositorys README if you don't mind. Unfortunately I have no experience with state of the art web development frameworks but if I can contribute something else based on my experience with the java implementation of the game, please just let me know.

eioo commented 3 years ago

Thank you very much. This really helps to make the code more readable.

Off-topic: I am aware of your reimplementation-efforts and follow the progress regularly. I am also very impressed of your work and would like to mention https://github.com/eioo/minigolf in this Repositorys README if you don't mind. Unfortunately I have no experience with state of the art web development frameworks but if I can contribute something else based on my experience with the java implementation of the game, please just let me know.

Glad to hear you have interest in our web project, I give 👍 for the README mention.

@Nokkasiili is currently converting Java functions to Rust so we'll have easy to read codebase we can both use/refer to, it should become public some time soon once we have all the obligatory game-related code done, it's still missing a few features. We'll be happy to contribute more to this project too, it would be awesome to see the java code fully de-obfuscated/optimized some day.

We're not actively looking for contributors in our project, at least at this point in time, thanks for the offer though. I'll let you know if we need some extra hands.