search

PhilippvK / playforia-minigolf

Client & Server for Minigolf Game known from Playforia/Playray/Appeli. Written in Java.
84 stars 31 forks source link

All tracks are missing trackSpecialSettings #87

Closed Nokkasiili closed 3 years ago

Nokkasiili commented 3 years ago

Example from Darwin - Two Snakes:S fttt12 Description of this string can be seen here: https://github.com/PhilippvK/playforia-minigolf/blob/85da3d2e0c9a62722ee3cd285f37c7ceaac57bee/client/src/main/java/agolf/game/GameChatPanel.java#L116

PhilippvK commented 3 years ago

Thanks for reporting!

Is this broken since #65 or was this never working in this repo?

Nokkasiili commented 3 years ago

Not sure but they are in old repo https://github.com/WorldStarHipHopX/playforia/blob/7a7e573a1688bf62f465173153f4936b27430be5/tracks/modern/Darwin-_sgard.track#L5

PhilippvK commented 3 years ago

@pehala Any opinion?

PhilippvK commented 3 years ago

The S Row was not documented in https://github.com/PhilippvK/playforia-minigolf/blob/master/doc/FileFormat.md as far as I can tell.

Nokkasiili commented 3 years ago

88

Nokkasiili commented 3 years ago

needs also be implemented here https://github.com/PhilippvK/playforia-minigolf/blob/master/shared/src/main/java/org/moparforia/shared/tracks/Track.java

pehala commented 3 years ago

Thanks for the report. It indeed looks like it is missing from my new implementation as it wasn't properly documented, is it an optional row or a mandatory one?

As you correctly point out the S row need to be implemented in all kinds of different places, since Track will be changed.

@Nokkasiili Would you like to try to add that to your PR or should I edit it? Since tracks are now covered by tests you should get a good idea if the new implementation is correct from them and compile errors combined.

Nokkasiili commented 3 years ago

https://github.com/PhilippvK/playforia-minigolf/blob/85da3d2e0c9a62722ee3cd285f37c7ceaac57bee/client/src/main/java/agolf/game/GameBackgroundCanvas.java#L13 Client will use default value if its missing