search

Phillipmartin / virustotal2

MIT License
10 stars 9 forks source link

Get rid of `postfile` class #3

Closed Fitblip closed 10 years ago

Fitblip commented 10 years ago

The Requests library can do multipart forms natively, and that class makes me sad (ThIs_Is_tHebouNdaRY?).

http://stackoverflow.com/questions/12385179/how-to-send-a-multipart-form-data-with-requests-in-python

It also doesn't adhere to standard class inheritance (not that it needs to with all staticmethods), and a few other issues, but since it's only used in one place I think it can be easily removed.

Phillipmartin commented 10 years ago

yeah that class made me sad too. that's what I get for being lazy and copy/pasting stuff from virustotal

Fitblip commented 10 years ago

Cool, I'll probably crank that out tonight and submit a PR.