search

PhillyOpen / Cycle-Philly-iOS

CyclePhilly for iPhone
www.cyclephilly.org
GNU General Public License v3.0
2 stars 8 forks source link

References to Cycle Atlanta in Code #4

Open AcriCAA opened 11 years ago

AcriCAA commented 11 years ago

I updated most of the references to Cycle Atlanta or otherwise noted that Cycle Atlanta's app was adapted for Philadelphia deployment.

However, the following references to Cycle Atlanta are embedded in the Code and may need to be updated to Cycle Philly references:

CycleAtlantaAppDelegate.h Cycleatl-Protocol-Version cycle**notedata******atlanta application/vnd.cycleatl.trip-v3+form

themightychris commented 11 years ago

It might be good to connect with the original authors and come up with a unique generic name for this thing so every city isn't dealing with find/replace On Aug 21, 2013 6:50 PM, "Corey Acri" notifications@github.com wrote:

I updated most of the references to Cycle Atlanta or otherwise noted that Cycle Atlanta's app was adapted for Philadelphia deployment.

However, the following references to Cycle Atlanta are embedded in the Code and may need to be updated to Cycle Philly references:

CycleAtlantaAppDelegate.h Cycleatl-Protocol-Version cycle**notedata******atlanta application/vnd.cycleatl.trip-v3+form

— Reply to this email directly or view it on GitHubhttps://github.com/PhillyOpen/Cycle-Philly-iOS/issues/4 .

cledantec commented 11 years ago

seems sensible (i've been getting some messages through github but not all, so simply jumping in here). there are a couple of places where it probably makes sense to come up with generic names: the form-post boundary string and the name of the datastore in iOS. since you've just gone through the find/replace exercise, feel free to add to that list and we can work up a common vocabulary for shared components.

also, thinking about the datastore, one bit that's missing and it might be good to add before you release (saving you the hassle of having to migrate the store should it be used in the future) is an attribute in the Trip entity for saved_trip_id or some such. this would allow us to send the trip_id created when trip was uploaded back to the phone, creating a hard reference between the two instances of the trip (the one in the phone and the one in the db). right now there's no hard reference, the closest we get is using the timestamps but i've found that to be a bit unreliable (also, note that on the trip download code i've had to do some math bcs our host is in CA so all the timestamps are off by 3 hours, this might cause you fits if your host is local).

hope this helps, happy to chat more if it's helpful.

best, cL

On Aug 21, 2013, at 11:44 PM, Chris Alfano notifications@github.com wrote:

It might be good to connect with the original authors and come up with a unique generic name for this thing so every city isn't dealing with find/replace On Aug 21, 2013 6:50 PM, "Corey Acri" notifications@github.com wrote:

I updated most of the references to Cycle Atlanta or otherwise noted that Cycle Atlanta's app was adapted for Philadelphia deployment.

However, the following references to Cycle Atlanta are embedded in the Code and may need to be updated to Cycle Philly references:

CycleAtlantaAppDelegate.h Cycleatl-Protocol-Version cycle**notedata******atlanta application/vnd.cycleatl.trip-v3+form

— Reply to this email directly or view it on GitHubhttps://github.com/PhillyOpen/Cycle-Philly-iOS/issues/4 .

— Reply to this email directly or view it on GitHub.