PhillyPythonWorkshop / PhillyPythonWorkshop.github.io

Curriculum for the Philly Python Workshop
http://phillypythonworkshop.github.io/
2 stars 4 forks source link

Bring code into PEP-8. Make responses and exit command case insensitive. #16

Closed FlipperPA closed 7 years ago

FlipperPA commented 7 years ago

What do we think about introducing "upper()"? I probably should have broken this into two requests, one for PEP-8 and one for "upper." Let me know if we want to remove "upper" and I'll amend, otherwise, we can keep it. :)

aelavender commented 7 years ago

👍 PEP-8 changes.

Re: upper ... Last time, I saw students enter un-capitalised capitals and see it say incorrect. Perhaps a good teachable moment that string equality is case-sensitive?

FlipperPA commented 7 years ago

What do y'all think? Keep the upper() or lose it?

maneesha commented 7 years ago

We talked about having some exercises around how to enhance the state capitals project. Maybe rather than changing the code, we give students the exercise and have them figure out how to deal with capitalization.