PhiloBiblon / philobiblon-ui

PhiloBiblon UI
Creative Commons Attribution Share Alike 4.0 International
0 stars 0 forks source link

FactGrid search box in every table #139

Open faulhaber opened 1 week ago

faulhaber commented 1 week ago

The simple search in all tables should function like the FactGrid search box. As you start to type a list of possible targets begins to appear. If the desired TARGET does not, the option "Search in the pages that contain TARGET"

jmformenti commented 5 days ago

Implementation hint:

To implement the option "Search in the pages that contain TARGET" we can run a more complex query (and slower) searching in all the claims and qualifiers of each PhiloBiblon item in Wikibase. Fortunately that is what we did before for simple search, so we can recover that query to implement this new option. See: https://github.com/PhiloBiblon/philobiblon-ui/commit/b3b718711d176250c41a65e8c60574bed535c0cd (query.service.js)

faulhaber commented 5 days ago

The pb.cog query is almost instantaneous. As soon as you start to type it begins to narrow the potential TARGETs down.