search

PhilterPaper / Perl-PDF-Builder

Extended version of the popular PDF::API2 Perl-based PDF library for creating, reading, and modifying PDF documents
https://www.catskilltech.com/FreeSW/product/PDF%2DBuilder/title/PDF%3A%3ABuilder/freeSW_full
Other
6 stars 7 forks source link

Reorganise t/tiff.t slightly to save boilerplate #164

Closed carygravel closed 3 years ago

carygravel commented 3 years ago

Now all package combinations are being tested in the CI, there is no change of missing anything.

PhilterPaper commented 3 years ago

We went through this before with consolidating multiple "skips" into one. It can't be done because it works inconsistently, at least under Windows. I thought you found that you had the same problem in Linux at some points.

Was there anything else changed that adds new function to the test?

carygravel commented 3 years ago

It really does work consistently under Windows. This is another reason why we set up everything also to run on Windows in the CI. I've never had a problem with the skips - at least when I did it was my own stupidity.

There are no other changes.

PhilterPaper commented 3 years ago

I don't think this is good style to consolidate this much, just to save a little "boilerplate". My problem with it is that it makes it prone to error if you want to insert or remove some tests (and forget to update the skip number, or unnecessarily skip an inserted new test with different requirements). Having the skip information repeated at the top of each test (making them skip individually) reminds you of what is necessary for this particular test. Each test stands independently of the others, permitting easy insertion, deletion, or re-ordering of the tests without getting tangled up in massive skip sections.

I appreciate the effort you put into this, but I just don't think I want to do this. Therefore I am closing this PR.