PhinchApp / Phinch

Phinch is a data visualization framework aimed at promoting novel explorations of large biological datasets (microbiomes, metagenomes, etc.). Features include support for HDF5 and JSON BIOM files, retooled visualizations, improved image export and sharing, and the ability to work offline.
BSD 2-Clause "Simplified" License
37 stars 9 forks source link

Numeric values in metadata must be given as String #26

Open thomasstjerne opened 6 months ago

thomasstjerne commented 6 months ago

Thanks for this great project! I was trying to load a BIOM file where some metadata are given as Numbers (Float or Int). This makes the Phinch app Crash as it calls the split function assuming it is a string: https://github.com/PhinchApp/Phinch/blob/63c26ef878178517c594c28db6657b5ddc711a29/app/components/Filter.js#L408

I realised that the flagship datasets actually have numeric data stored as ASCII strings, which is why they do not crash the app.