Phixyn / no-bs-looper

A mobile-friendly website that loops YouTube videos. It can loop an entire video or a portion of it. Easy to use with no distractions.
http://ytlooper.phixyn.com
GNU General Public License v3.0
3 stars 1 forks source link

Refactor: Check server messages in client's message handler #83

Closed Phixyn closed 4 years ago

Phixyn commented 4 years ago

Pull Request Submission

Thank you for taking the time to contribute to this project! Please take the time to tell us a bit about the changes you've made.

Description

Give a short and brief description of the pull request. Add a screenshot if appropriate and helpful. Changes can be listed in the next section.

Updates the server message payloads to include a type and wrap the content in a content object. Updates the client to handle these new message formats, as well as the error messages sent by the server.

Closes #46.

Changes

List the changes made.

Breaking Change?

Will these changes cause existing functionality to not work as expected? Will contributors be able to run the project after these changes are merged, without needing to take any additional steps?

Client-server communication protocol update.

Changes were made to the contents and structure of messages sent by the server. This PR updates the client accordingly. After merging this PR, no further action is needed to address the breaking change.

Merging Checklist

Lastly, before merging we need to make sure that these are done.