Phixyn / redhawk

My personal portfolio website and blog. It's a Jamstack website made with Gridsome (think Gatsby, but for Vue.js) and backed by a Strapi CMS instance.

https://phixyn.com

2 stars 0 forks source link

Remove unnecessary title attributes #141

Closed Phixyn closed 3 years ago

Phixyn commented 3 years ago

Pull Request

Description

Give a short and brief description of the pull request. Add a screenshot if appropriate.

Title attributes that didn't add any value to their elements (e.g. just repeating the link text) have been removed. Same for some figure elements.

Changes

List the changes made.

Removed unnecessary title attributes from links
Removed title attribute from project page's carousel figure element (keeping the ones in the indicators)
CMS: Removed unnecessary title attributes from various links in content pages like "About" and homepage

Breaking Change?

Will these changes cause existing functionality to not work as expected? Will contributors be able to run the project after these changes are merged, without needing to take any additional steps?

[ ] Tick if this is a breaking change and describe why below

Merging Checklist

Lastly, before merging we need to make sure that these are done.

[x] Project builds and runs
[x] All changes were tested
~~All tests are up-to-date~~
~~All tests pass~~
[x] Code style follows the JavaScript and Vue.js style guides
[x] Code documentation is up-to-date
[x] Project documentation is up-to-date