search

PhlexPlexico / G5V

A front-end for G5API to manage matches/seasons/tournaments for CS:GO
MIT License
56 stars 29 forks source link

Allow for custom api host url #72

Closed kdev closed 3 years ago

kdev commented 3 years ago

closes #71

IMPORTANT: The URL should include http(s)://

PhlexPlexico commented 3 years ago

I do like the idea of this as it does give some more refinement for users to choose the endpoint they wish to have. Has this been tested, though? I'd be wary to change all these endpoint calls and not have them work 😅 so long as it's tested I'll merge it in!

kdev commented 3 years ago

there is no reason it shouldn't tbh, because I am not changing anything critical but will test it anyways

kdev commented 3 years ago

Using ENVs seems to be quite complicated as described here

This looks almost impossible because ENVs are resolved at buildtime not runtime. The only way to get this working is by having a .env.production while building

kdev commented 3 years ago

Should I do some documentation work on this? Or would you like to do it?

PhlexPlexico commented 3 years ago

If you could do the documentation that would be wonderful :) it seems fairly straightforward, but would be nice to append to the README, especially for the Dockerfile as well.

kdev commented 3 years ago

Will do ^^

kdev commented 3 years ago

This is ready to be merged!