search

PhlexPlexico / G5V

A front-end for G5API to manage matches/seasons/tournaments for CS:GO
MIT License
56 stars 29 forks source link

Added DockerfileLightCaddy & Fixed the Caddyfile #90

Closed kubo6472 closed 2 years ago

PhlexPlexico commented 2 years ago

I am still relatively new to Caddy as well, but my setup was following the setup I had in the wiki for single domains, since this container will only be running one domain. Have you tested the handle_path directive extensively? I know I had some issues with initial testing before reaching the end product [here[(https://github.com/PhlexPlexico/G5V/wiki/Webserver-Setup-With-Caddy) with having to strip prefixes, or you would get 404's if someone went to https://your.get5.instance/api/matches/ (notice the ending /, if that doesn't get removed it 404s). But if you can confirm all the traversing (going to the API, loading app, pressing back button doesn't produce a 404), then this should be good to merge in :)

PhlexPlexico commented 2 years ago

Oh! Speaking of, and looking back at the branch you wish to merge into - I now remember the problem that I ran into with Caddy! Since Caddy requires variables for reverse proxy, nostname, and the API endpoint at build time, there is no possible way for this to be created into a package like the NGINX version! That's the one main issue I had when looking into this. However, we can still merge it in, but just know that it won't be at all possible to have this in a docker-compose file due to this issue!

Thanks!

PhlexPlexico commented 2 years ago

Updated the readme to fix the change issue and the Caddyfile to reflect your changes, just delete the dockerfilefullcaddy and we should be good to merge in!

kubo6472 commented 2 years ago

you got it :)