search

PhlexPlexico / G5WS

Game Server Plugin for G5API
https://phlex.avidgamers.me
GNU General Public License v3.0
18 stars 8 forks source link

sm-ripext 1.3.0 #20

Closed thewickerman22 closed 3 years ago

thewickerman22 commented 3 years ago

Deprecated HTTPClient methodmap Introduced HTTPRequest methodmap pls update if possible

PhlexPlexico commented 3 years ago

Check the utility-knife-dmg branch. That has the new requests implemented but please note there are currently issues with POST data not being sent.

Just because it's deprecated right now doesn't mean you can't use it. I would much rather switch over when everything is 100% stable :)

Thanks!

thewickerman22 commented 3 years ago

thanks for the reply

thewickerman22 commented 3 years ago

i have tried compling with the branch u said but i m getting compilation errors. i will give another try

PhlexPlexico commented 3 years ago

The only warning I was getting was teh sHHTPTags was unused? In which case, I removed those. what other errors are you getting?

thewickerman22 commented 3 years ago

ok the plugin is compiled thanks

thewickerman22 commented 3 years ago

G5WS.smx (G5WS - Get5 Web Stats): Native "HTTPRequest.HTTPRequest" was not found getting this error

PhlexPlexico commented 3 years ago

Did you include the natives and source from rest in pawn when compiling? That just means you're missing the library/source from it when trying to compile. Please ensure your sourcemod installation has the source for Rest in Pawn

PhlexPlexico commented 3 years ago

For more info you can see how GitHub actions compiles this here https://github.com/PhlexPlexico/get5-webapi/blob/utility-knife-dmg/.github/workflows/make_release.yml

thewickerman22 commented 3 years ago

i m compiling in windows. i have included the latest sm source as well as RIP. do i need anythin extra for compiling. as per the workflow i have done everything still getting the error when plugin is uploaded to the server :(

PhlexPlexico commented 3 years ago

Did you include Ripext on your Windows server in addons/sourcemod/extensions or whichever directory it should be in?

thewickerman22 commented 3 years ago

yes i did

thewickerman22 commented 3 years ago

1

thewickerman22 commented 3 years ago

did for 64-bit also

PhlexPlexico commented 3 years ago

sm extensions list in your game server. Does rest in pawn appear?

thewickerman22 commented 3 years ago

yea

thewickerman22 commented 3 years ago

1

thewickerman22 commented 3 years ago

2

PhlexPlexico commented 3 years ago

1.1.1? You need 1.3. httprequest was just implemented in 1.3, not 1.1.1.

thewickerman22 commented 3 years ago

ok my bad sorry

PhlexPlexico commented 3 years ago

No worries! But please note that there are currently potential issues surrounding this plugin/RiP and windows servers. If you run into updates not being sent across, this may be the case.

thewickerman22 commented 3 years ago

ok

thewickerman22 commented 3 years ago

it is possible to use steamworks instead of RIP for G5 api. yesterday i checked the code of splwis. he had used steamworks for creating HTTP requests handle

PhlexPlexico commented 3 years ago

The reason I chose ripext over Steamworks was because I am able to send an octet stream over HTTP, which allows demo uploads once a match finishes. If you want to use the old plugin, the API should be compatible with the old plugin as well, since I tried to keep it backwards compatible. But you will lose functionality such as demo uploads, veto picks, and side picks.

Also, since the issue was resolved, I'm going to close this for now since it's getting off topic. You can feel free to keep track in the issue linked above for when this other change may be fixed.

Thanks!