PhlexPlexico / G5WS

Game Server Plugin for G5API
https://phlex.avidgamers.me
GNU General Public License v3.0
18 stars 8 forks source link

[Actions BUG] releases being marked as draft #26

Closed kubo6472 closed 3 years ago

PhlexPlexico commented 3 years ago

So the reason why I have these kept as drafts is because I don't actually want to make a release every time, to be honest. The way it presents the title of the release, and the tag itself, isn't really.... Smart compared to how I've done it after this one.

It may require a bit more work than just setting the draft, but I would prefer setting it as a prerelease like this -

https://github.com/gamestabled/OoT3D_Randomizer/blob/ac0243ad68f69b604d710c6abc06f95273b567b6/.github/workflows/create_nightly.yml#L22-L42

Of course without the downloads in the body, haha. So maybe making it a bit more informative would be better right now :)

kubo6472 commented 3 years ago

Just uploading the compiled asset to actions would be enough tbh. just that every sourcepawn I compiled to this date had some issues compared to the ones I got from your releases. All I was gonna ask, was if you planned on releasing Fix check for client num release since I use the coaches on almost every match now.

PhlexPlexico commented 3 years ago

Ah! I see what you mean. I thought I had it uploading to artifacts as well. The only reason I don't have them listed as releases right now is due to the fact that I haven't tested it, so I don't know if they're stable enough yet or not. I'll go mark this one as a pre-release for now, and will update the action to start providing pre-releases instead :)

E: Prerelease is now marked, you should be able to find it on the release page!

kubo6472 commented 3 years ago

Thanks for the prerelease. On that artifact note, this is a very useful tool: https://nightly.link/phlexplexico/g5ws/workflows/make_release/master closing this and the PR then