search

PhlexPlexico / get5-web

[END OF LIFE] Webpanel for servers using the get5 CS:GO server plugin
GNU General Public License v3.0
21 stars 10 forks source link

[BUG] Not able to access match as SA or Admin #147

Closed bjerrecs closed 4 years ago

bjerrecs commented 4 years ago

Describe the bug Installed the Get5 Web as per standard. Can create matches, seasons and more.

All works fine.

But i cant access the match while its live?

Here are the screenshots off the results of pressing the match ID buttom.

First screenshot of error is from superadmin and the other is from a normal admin chrome_Zg69EGQ6PP chrome_8HKpO1uX40 chrome_p1hd2ZTaNo

Which Build Get5 d0477c6+

PhlexPlexico commented 4 years ago

Wait, actually found it. https://github.com/PhlexPlexico/get5-web/blob/master/get5/match.py#L699 just needs to be is_admin not lis_admin. Will fix.

PhlexPlexico commented 4 years ago

PR #148 should fix this. Please confirm, thanks!

mrc4tt commented 4 years ago

I can confirm, this happens if I setting 1 match to being: Private Match

Sorry, unexpected error: 'BaseQuery' object is not callable - and this happens, if I edit on database set match 1 to being private match and clicking on the match (as admin, and I get the error!)

PhlexPlexico commented 4 years ago

And are you running the latest version after PR #148 was updated? If so, please supply the log at the time of error. Thanks!

mrc4tt commented 4 years ago

And are you running the latest version after PR #148 was updated? If so, please supply the log at the time of the error. Thanks!

Yes, I did installed it yesterday! ;) if I looking on Match.py (it's updated, as you did fix! with "lis_admin" to "is_admin" ;)

Pastebin for errors: https://pastebin.com/wMDyjsLp build: a668e46

PhlexPlexico commented 4 years ago

For reference this is where it's failing and it's to do with logic of selecting the PlayerStats model. Will look into later.

Should maybe replace that list to combine with this: playerstats_steam = [r.steam_id for r in PlayerStats.query.filter(PlayerStats.match_id=match.id)] on that line. That may fix it.

PhlexPlexico commented 4 years ago

Latest development push should fix it.

bjerrecs commented 4 years ago

Can confirm the fix worked on my end! Thanks!