PhlexPlexico / get5-web

[END OF LIFE] Webpanel for servers using the get5 CS:GO server plugin
GNU General Public License v3.0
21 stars 10 forks source link

[Feature Request] Change servername after match finish? #153

Closed mrc4tt closed 4 years ago

mrc4tt commented 4 years ago

Describe the bug (apistats or get5 plugin?) or somehow changes servername back (from server.cfg) after the match finishes (e.g: 16-0) - with get5

Which Build master.

To Reproduce Steps to reproduce the behavior:

  1. Create a match
  2. Play the match.
  3. Finish match after 16-0.
  4. Servername is still: Get5: Team1 vs Team2

Expected behavior It should change the servername from the "server.cfg" where hostname is inserted. Example: MrC4t Server.

PhlexPlexico commented 4 years ago

That's more of a get5 question I would think, as I feel like that should be a feature of get5 when a match ends.

PhlexPlexico commented 4 years ago

For right now, I'm going to label this as wontfix and help wanted, as it would be something easy as a first issue if someone wants to modify the sourcemod plugin.

TandelK commented 4 years ago

This will require a bit of rework after Get5 finish all the events not after Map Change because if there are BO2 or more it wont work. Just need to add command to execute server.cfg where hostname might be set to exec after match/series completion.

PhlexPlexico commented 4 years ago

Uhhh not really, it won't. What I would recommend is creating a new value for the API Stats plugin. Name it something such as g_DefaultServerNameCvar and create a convar that can be stored in the config file. Once that's done you use some sourcemod magic to get and set the convarstring hostname on the series result in the plugin, for example here.

PhlexPlexico commented 4 years ago

I saw that you created a ticket with the get5 plugin, and it seems that is supposed to be the intended functionality of get5. Would you mind if we closed this ticket, since it's more relational to that plugin?