[WIP] Convert to Rails Engine with dummy app

PhlexUI / phlex_ui

Ruby gem for Phlex UI Components

https://phlexui.com/

MIT License

115 stars 11 forks source link

[WIP] Convert to Rails Engine with dummy app #33

Closed coderberry closed 4 months ago

coderberry commented 5 months ago

WIP

This PR converts this gem into a Rails mountable engine. This change provides the following:

Built-in Lookbook (by adding mount PhlexUI::Engine, at: "/phlex_ui")
A dummy app in which we can test the gem setup and usage
bin/rails s runs the dummy app in which we can access "/phlex_ui" at http://localhost:3000
bin/rails c runs the rails console for the dummy app, allowing us to debug the components and integration
...

iseth commented 4 months ago

I think it would be better to have a separate app that would include the mountable engine. That way this stays slim. What are your thoughts?

iseth commented 4 months ago

To further elaborate... it would be nice to have a more elaborate structure to allow the installation of the component itself like shadcn does but also have the option to just use the referenced file from the gem, while also supporting Sinatra or any other framework. I was worried about putting a lot of specific rails stuff into the main gem iteself and keep it more like phlex does with phlex-rails.

coderberry commented 4 months ago

| it would be nice to have a more elaborate structure to allow the installation of the component itself like shadcn does but also have the option to just use the referenced file from the gem, while also supporting Sinatra or any other framework.

@iseth I agree. This is something I've found quite nice with the ShadCN Rails Components. These projects are quite similar, but take a different approach.

I'm closing this PR.