search

Phlow / feeling-responsive

»Feeling Responsive« is a free flexible theme for Jekyll built on Foundation framework. You can use it for your company site, as a portfolio or as a blog.
http://phlow.github.io/feeling-responsive/
MIT License
891 stars 1.32k forks source link

include a gemspec in the gh-pages branch #194

Closed thedavidmeister closed 3 years ago

thedavidmeister commented 4 years ago

discussion here https://github.com/Phlow/feeling-responsive/issues/193

cgodefroy commented 4 years ago

Yes, it would be helpful, especially for Amplify which needs the git repo address and branch.

thedavidmeister commented 4 years ago

@Phlow as the bare bones version was deleted without adding/copying the gemspec across i've got failing builds now that can't be fixed until this happens :(

ifreund commented 4 years ago

The unannounced deletion of the bare bones branch broke my site as well.

Phlow commented 4 years ago

I am truly sorry. I didn‘t know, that when I delete something in my repo It would affect other repositories.

ifreund commented 4 years ago

I mean in retrospect I should have forked your repo and based my build off of that, but I didn't so the build failure was pretty confusing till I realized the branch here was gone.

Phlow commented 4 years ago

Please have a look at the normal version. There you should find all the necessary parts.

thedavidmeister commented 4 years ago

@Phlow i still don't see a gemspec https://bundler.io/man/gemfile.5.html#GEMSPEC file in the normal version

this is what is needed (and was removed):

https://github.com/thedavidmeister/feeling-responsive/blob/2020-01-09-art/jekyll-theme-feeling-responsive.gemspec

Phlow commented 4 years ago

Can you make a pull request and I add it.

thedavidmeister commented 4 years ago

@Phlow i'm a bit confused because the original gemspec came from you... it's just that it was in one branch and not the other...

Phlow commented 4 years ago

It was a suggestion › I found the original source › https://github.com/Phlow/feeling-responsive/pull/159

Please make a pull request and I add it. I don't really know what the gemspec does ;)

thedavidmeister commented 4 years ago

@Phlow the gemspec allows someone to point to the github repo and have ruby pull the theme in, rather than copying and pasting and committing a bunch of files

that way every file in the repo is just an override, which makes it more maintainable

https://jekyllrb.com/docs/themes/#understanding-gem-based-themes

Phlow commented 4 years ago

OK. I understand. Do you make a pull request for the desired file? That's the easiest for me.

Phlow commented 3 years ago

Added.