search

Phlow / feeling-responsive

»Feeling Responsive« is a free flexible theme for Jekyll built on Foundation framework. You can use it for your company site, as a portfolio or as a blog.
http://phlow.github.io/feeling-responsive/
MIT License
901 stars 1.34k forks source link

Absolute URL in navigation.yml is prefixed by site.url, but it should not #195

Closed fedorov closed 5 years ago

fedorov commented 5 years ago

I configured one of the top-level navigation items to point to an external https URL, but somehow it is prefixed by the base URL.

The way I understand, it is configured in this line: https://github.com/fedorov/idc-feeling-responsive/blob/gh-pages/_data/navigation.yml#L18, and it parameterizes this template (or whatever it is called), and this line tells it should not prefix with domain, but for whatever reason it does prefix it: https://github.com/fedorov/idc-feeling-responsive/blob/gh-pages/_includes/_navigation.html#L30.

Any thoughts what I am doing wrong?

fedorov commented 5 years ago

I could not figure this out quickly, so I just removed those menu items, so links above will not work for the master. The tree of the code with the issue is here: https://github.com/fedorov/idc-feeling-responsive/tree/acdf94d3ad858bb172c65c3ff2d26ea0968f0445.

https://github.com/fedorov/idc-feeling-responsive/blob/acdf94d3ad858bb172c65c3ff2d26ea0968f0445/_data/navigation.yml#L18

fedorov commented 5 years ago

@notZaki figured it out in this PR: https://github.com/fedorov/idc-feeling-responsive/pull/1

fedorov commented 5 years ago

@Phlow isn't this something that should be fixed in this repository: https://github.com/ImagingDataCommons/imagingdatacommons.github.io/pull/1/files#diff-279d32205f7efe0a57bb5c60fe477b70R32

Phlow commented 5 years ago

I fixed it. Forgot to push it ;)

fedorov commented 5 years ago

got it! for completeness, this was fixed in https://github.com/Phlow/feeling-responsive/commit/6f027f1546d8ce88d4efef5d7fdec9a8c76734d2#diff-279d32205f7efe0a57bb5c60fe477b70