Phlow / feeling-responsive

»Feeling Responsive« is a free flexible theme for Jekyll built on Foundation framework. You can use it for your company site, as a portfolio or as a blog.
http://phlow.github.io/feeling-responsive/
MIT License
896 stars 1.33k forks source link

Getting a build error #267

Open Ram-N opened 1 year ago

Ram-N commented 1 year ago

I forked this repo, and under settings-->Pages, I switched to the 'gh-pages` branch. No other changes made. And I get the following build error from Github.

Rendering: _posts/design/2015-08-16-typography.md Conversion error: Jekyll::Converters::Scss encountered an error while converting 'assets/css/styles_feeling_responsive.scss': $number: "calc($colNumber / $totalColumns)" is not a unitless number forpercentage' on line 32 `

Any help or suggestions are appreciated. (It runs fine in my local though)

esorolla commented 1 year ago

I have the same problem.

baxendaleink commented 1 year ago

Me as well.

baxendaleink commented 1 year ago

After some brief research online, I removed the header section of the file (assets/css/styles_feeling_responsive.scss), to remove the section with the dashes, and it fixed the issue.

I cannot say why or if I've made things worse by doing so, though, because I'm too amateur here for that. As below, this is everything I removed:

---
# Only the main Sass file needs front matter, rest is included from site.sass.sass_dir
sitemap:
  exclude: true
---

So the file now looks just like this:

@charset "utf-8";

@import "functions.scss";
@import "01_settings_colors.scss";
@import "02_settings_typography.scss";
@import "03_settings_mixins_media_queries.scss";
@import "04_settings_global.scss";
@import "05_normalize.scss"; // normalize.css v3.0.2

@import "foundation-components/top-bar";
@import "foundation-components/accordion";
@import "foundation-components/alert-boxes";
@import "foundation-components/breadcrumbs";
@import "foundation-components/block-grid";
@import "foundation-components/button-groups";
@import "foundation-components/buttons";
@import "foundation-components/clearing";
@import "foundation-components/dropdown";
@import "foundation-components/dropdown-buttons";
@import "foundation-components/flex-video";
@import "foundation-components/forms";
@import "foundation-components/grid";
@import "foundation-components/inline-lists";
@import "foundation-components/keystrokes";
@import "foundation-components/panels";
@import "foundation-components/reveal";
@import "foundation-components/side-nav";
@import "foundation-components/sub-nav";
@import "foundation-components/tables";
@import "foundation-components/thumbs";
@import "foundation-components/top-bar";
@import "foundation-components/type";
@import "foundation-components/visibility";

@import "06_typography.scss";
@import "07_layout.scss";
@import "foundation-components/grid";
@import "09_elements.scss";

{% if site.asciidoctor-enabled == true %}
@import "10_asciidoc.scss";
{% endif %}

@import "11_syntax-highlighting.scss";

Hope that helped somebody.

TWiStErRob commented 1 year ago

This theme on the latest commit is built with Jekyll 4 on Ruby 3. GitHub pages only supports Jekyll 3: https://github.com/github/pages-gem/issues/651 I think you'll need to use a custom GitHub Actions workflow to deploy to Pages: https://github.com/github/pages-gem/issues/651#issuecomment-1197448026

@Phlow your deployment fails since the lock file changes, because you're also using the built-in gh-pages builder. Did you mean to use latest Jekyll 4?

@baxendaleink Removing the front matter like that will result in not processing that file at all, just plain raw copy, which means your site CSS will be non-existent. Make sure you're doing a full (non-incremental) jekyll build to observe this. Here's an example diff after removing front matter: image this explains why the error goes away: it's simply not processed.

baxendaleink commented 1 year ago

No way I'd have figured that out. Thank you. :)

sieb commented 11 months ago

I managed to solve it with Github Actions template Jekyll, just changing cache 0 to 1 cache-version: 1 # Increment this number if you need to re-download cached gems Look in https://sieb.github.io/feeling-responsive/

simopal6 commented 10 months ago

I managed to solve it with Github Actions template Jekyll, just changing cache 0 to 1 cache-version: 1 # Increment this number if you need to re-download cached gems Look in https://sieb.github.io/feeling-responsive/

Can you please in more detail? I also tried enabling the GitHub Action, changing cache-versionto 1, but I still get a build error.

sieb commented 9 months ago

I managed to solve it with Github Actions template Jekyll, just changing cache 0 to 1 cache-version: 1 # Increment this number if you need to re-download cached gems Look in https://sieb.github.io/feeling-responsive/

Can you please in more detail? I also tried enabling the GitHub Action, changing cache-versionto 1, but I still get a build error.

I tested it now, in the following workflow:

Nikoleta-v3 commented 6 months ago

Thank you @sieb! Your comments and suggestions where very helpful 😄 🥳