search

Pho3niX90 / solis_modbus

Home Assistant HACS integration for Solis inverters
16 stars 0 forks source link

Bugs with sensors for Battery Charge / Discharge #22

Closed 0rangutan closed 6 months ago

0rangutan commented 6 months ago

Possible issues with battery related sensors:

  1. The Solis Battery Force-charge Power Limitation sensor reads as 50W in the integration Sensors but 500W in the integration Controls and also Solis Cloud. So I think out by factor of 10 somewhere?
  2. Solis Battery Power is the sensor for the power currently going into the battery to charge it so perhaps this could be re-named to indicate the charging, eg. Solis Battery Charge Power?
  3. I can't find an equivalent sensor for power currently being discharged from the battery (eg. Solis Battery Discharge Power) - Have I missed this somewhere?
Pho3niX90 commented 6 months ago

What do you mean by point 3? The charge sensor would be sensor.solis_battery_charge_power and discharge sensor.solis_battery_discharge_power

0rangutan commented 6 months ago

Apologies for any confusion. Are you saying that I should use sensor.solis_battery_charge_power and sensor.solis_battery_discharge_power ? Neither are present in my instance of your integration. Should they be?

Point 3 was requesting that a Battery Discharge sensor be added.

Is the problem that they are missing from my setup or from your integration?

Pho3niX90 commented 6 months ago

They are definitely in the integration, question is just why they would be missing for you, which would mean it's a bug in any case.

How many sensors is the integration reporting? It should be around ~145

Pho3niX90 commented 6 months ago

For the other points

  1. This is definitely a bug, and will address this. The input number. is the correct value.
  2. Battery power is a signed 32, however, solis just returns this as a positive, direction is determined by Solis Battery Current Direction. if Solis Battery Current Direction == 0, then it's charging, if it's 1, then it's discharging.
Pho3niX90 commented 6 months ago

I was mistaking about sensor.solis_battery_charge_power and sensor.solis_battery_discharge_power. It seems I had this as a template sensor in my configuration. I will defnitely add these sensors.

0rangutan commented 6 months ago

Ah, great - that all makes sense now. Yes please - adding these as sensors in the integration would be very helpful.

Pho3niX90 commented 6 months ago

So the 2 sensors have been added in 1.3.0. I am still investigating how to properly handle point 1

0rangutan commented 6 months ago

All working well now, many thanks