search

Phobetor / rabbitmq-supervisor-bundle

Symfony bundle to automatically create and update supervisor configurations for RabbitMQ consumer daemons
MIT License
104 stars 42 forks source link

Command does not exit #29

Closed yourilefers closed 6 years ago

yourilefers commented 6 years ago

This may be by design, but the init commands (like start) do not exit properly when used in combination with Docker (Compose). I fixed this by migrating from the Process->run command to the Process->start command. It may be a good idea to make this an option, as "start" should just start the daemon and than exit the command. "Run" will wait for the command to exit, which gave problems running it with "docker exec".

For reference; I used Symfony 3.x and PHP-FPM 7.1.

tackerm commented 6 years ago

I can confirm this issue, although in a different setup. The Supervisor::run() method hangs when calling $this->getContainer()->get('phobetor_rabbitmq_supervisor')->start() in a custom console command. Replacing $p->run() with $p->start() fixes it.

Also note that calling wait() after run() doesn't make much sense, as run() already calls wait() internally...