2 issues about Kit/Disguise

reedom114514 commented 4 months ago

Description

1 you cannot see your allies' mirage tank 2 some infs (ex. Saboteur in MO3, a kind of spy inf) become a strange blue shadow when paradropped, this might be the problem of infs paradrop rather than kitup though

Phobos Version

b40/b41

Conditions to reproduce

MO3.3.6 with old syringe

INI code

Self explained

Steps to reproduce

Building a mirage tank and call the other player to see it Paradropping the spy

Expected behaviour

shown as normal

Actual behaviour

1 invisible 2 invisible, and strange blue shadows around

Additional context

Checklist

[X] The issue happens on the latest official version of Phobos and wasn't fixed yet.
[X] I agree to elaborate the details if requested and provide thorough testing if the bugfix is implemented.
[X] I added a very descriptive title to this issue.
[X] I used the GitHub search and read the issue list to find a similar issue and didn't find it.
[X] I have attached as much information as possible (screenshots, gifs, videos, debug and exception logs, etc).

chaserli commented 4 months ago

set DisguiseBlinkingVisibility to team may solve it. It was drawing the conscript's paradrop frame with the sbtr's shp due to the discrepancy between IsAlliedWith wrapper and ControlledByCurrentPlayer wrapper in #653.

reedom114514 commented 4 months ago

set DisguiseBlinkingVisibility to team may solve it. It was drawing the conscript's paradrop frame with the sbtr's shp due to the discrepancy between IsAlliedWith wrapper and ControlledByCurrentPlayer wrapper in #653.

Confirmed, it works, THX!

Metadorius commented 4 months ago

I am not sure this should be closed. Per my understanding the default behavior was broken?

chaserli commented 4 months ago

I am not sure this should be closed. Per my understanding the default behavior was broken?

It is indeed incoherent

FS-21 commented 4 months ago

DisguiseBlinkingVisibility

Since the existence of DisguiseBlinkingVisibility feature the vanilla behaviour is broken and you have to add that tag with owner,allies (not at home so I don't know if I spelled it right or owner,team or similar combination) for fix the broken behaviour.

If you port the Allied RA2 mission of the Einsteins Laboratory the Mirage tank preview you'll see invisible units instead of trees.

Starkku commented 4 months ago

Should be fixed in 80c8e6ba8b0dc99d1cff4f442da14d2ad2e1db9b

Phobos-developers / Phobos